Invalid argument supplied for foreach on line 25 Error in my php and mysql

Question

Here is the PHP & MySQL code.

function make_comments($parent_comment_id = 0, $comment_id = 0) {
global $user_id;
global $comment_order;

foreach ($parent_comment_id as $id => $comment) {

    if($comment['user_id'] == $user_id && $comment['parent_comment_id'] == 0){
        $comment_id = $comment['comment_id'];
        echo '<div>' . $comment['comment'] . '</div>';

        if($comment_id  == $comment['parent_comment_id']){
            if($comment['user_id'] == $user_id && $comment['parent_comment_id'] >= 1) {
                $comment_id = $comment['comment_id'];
                echo '<div>' . $comment['comment'] . '</div>';
            } else if($comment['parent_comment_id'] >= 1) {
                $comment_id = $comment['comment_id'];
                echo '<div>' . $comment['comment'] . '</div>';
            }
        }           

    } else if($comment['user_id'] != $user_id && $comment['parent_comment_id'] == 0) {
        $comment_id = $comment['comment_id'];
        echo '<div>' . $comment['comment'] . '</div>';

        if($comment_id  == $comment['parent_comment_id']){
            if($comment['user_id'] == $user_id && $comment['parent_comment_id'] >= 1) {
                $comment_id = $comment['comment_id'];
                echo '<div>' . $comment['comment'] . '</div>';
            } else if($comment['parent_comment_id'] >= 1) {
                $comment_id = $comment['comment_id'];
                echo '<div>' . $comment['comment'] . '</div>';
            }
        }
    }       
        make_comments($comment_order[$id]);
    }
}

$dbc = mysqli_query($mysqli, "SELECT articles_comments.comment_id, articles_comments.parent_comment_id, articles_comments.comment, articles_comments.user_id FROM articles_comments LEFT JOIN users ON articles_comments.user_id = users.user_id WHERE article_id = '" . $article_id . "' ORDER BY articles_comments.parent_comment_id ASC");
if (!$dbc) {
    print mysqli_error();
} 

$comment_order = array();

while (list($comment_id, $parent_comment_id, $comment_text, $comment_user, $comment_id) = mysqli_fetch_array($dbc)) {
$comment_order[$parent_comment_id][$comment_id] =  array('parent_comment_id' => $parent_comment_id, 'comment_id' => $comment_id, 'comment' => $comment_text, 'user_id' => $comment_user, 'comment_id' => $comment_id);
}

make_comments($comment_order[0], $comment_id);

Answer 1

Hello @viven ,

This should be a simple fix to your code. It checks  $parent_comment_id is an array before executing the foreach loop.

if(is_array($parent_comment_id))
foreach ($parent_comment_id as $id => $comment) {
   //your for each code goes here
}

You can even add an else after the foreach.

Try this

Hope it works!!

Thank you!!

Comments

Thank you man..your tricks works

---

Hey, 

Glad to help you, please upvote the answer if you find it helpful. You can come to the community regarding any tech queries to gain points and for further contributions. You may ask questions, answer, upvote, and downvote an answer. Each of these would fetch you points and you could be among the top contributors and win exciting merchandise from Edureka.

Cheers!